-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace common.fixturesDir with fixtures #15946
Closed
AshleyRayMaceli
wants to merge
2
commits into
nodejs:master
from
AshleyRayMaceli:replace-fixtures-dir-with-fixtures-amaceli
Closed
test: replace common.fixturesDir with fixtures #15946
AshleyRayMaceli
wants to merge
2
commits into
nodejs:master
from
AshleyRayMaceli:replace-fixtures-dir-with-fixtures-amaceli
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelgolda
reviewed
Oct 6, 2017
@@ -17,7 +18,7 @@ const { connect: tls } = require('tls'); | |||
const countdown = (count, done) => () => --count === 0 && done(); | |||
|
|||
function loadKey(keyname) { | |||
return readFileSync(join(common.fixturesDir, 'keys', keyname)); | |||
return readFileSync(join(fixtures.fixturesDir, 'keys', keyname)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be using method fixtures.readKey
to get the keys.
Trott
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Oct 6, 2017
BridgeAR
approved these changes
Oct 7, 2017
The commit message has to be changed to include the subsystem. This can be done while landing though. |
cjihrig
approved these changes
Oct 7, 2017
joyeecheung
approved these changes
Oct 8, 2017
gibfahn
pushed a commit
that referenced
this pull request
Oct 8, 2017
PR-URL: #15946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Landed in 86d803b Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
http2
Issues or PRs related to the http2 subsystem.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: replace common.fixturesDir with fixtures
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)