Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace common.fixturesDir with fixtures #15946

Conversation

AshleyRayMaceli
Copy link
Contributor

@AshleyRayMaceli AshleyRayMaceli commented Oct 6, 2017

Task: replace common.fixturesDir with fixtures

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@@ -17,7 +18,7 @@ const { connect: tls } = require('tls');
const countdown = (count, done) => () => --count === 0 && done();

function loadKey(keyname) {
return readFileSync(join(common.fixturesDir, 'keys', keyname));
return readFileSync(join(fixtures.fixturesDir, 'keys', keyname));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be using method fixtures.readKey to get the keys.

@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeAR
Copy link
Member

BridgeAR commented Oct 7, 2017

The commit message has to be changed to include the subsystem. This can be done while landing though.

@joyeecheung
Copy link
Member

@gibfahn gibfahn self-assigned this Oct 8, 2017
gibfahn pushed a commit that referenced this pull request Oct 8, 2017
PR-URL: #15946
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Oct 8, 2017

Landed in 86d803b

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@gibfahn gibfahn closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #15946
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
PR-URL: nodejs/node#15946
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants